Conversation
klkvr
requested review from
0xKitsune,
0xrusowsky,
fgimenez,
legion2002 and
mattsse
as code owners
Contributor
|
Contributor
📊 Tempo Precompiles CoverageprecompilesCoverage: 5634/7729 lines (72.89%) File details
contractsCoverage: 1/226 lines (0.44%) File details
Total: 5635/7955 lines (70.84%) |
0xrusowsky
reviewed
May 6, 2026
| amount: U256::from(amount), | ||
| }, | ||
| )?; | ||
| fn transfer_from(&mut self, token: Address, sender: Address, amount: u128) -> Result<()> { |
Contributor
There was a problem hiding this comment.
should we create this fn as a new TIP20 helper (i.e transfer_from_internal(&mut self, caller: Address, from: Address, amount: U256) which routes based on AddressRegistry::is_implicitly_approved()?
it would ensure that impl and registry are always aligned + that to is always the caller precompile
legion2002
reviewed
May 6, 2026
| /// Precompiles on this list are authorized to call | ||
| /// [`crate::tip20::TIP20Token::system_transfer_from`], pulling TIP-20 tokens from a user without a | ||
| /// prior `approve()`. The list is gated on `TempoHardfork::T5`; before activation it is empty. | ||
| pub const IMPLICIT_APPROVAL_LIST: &[Address] = &[TIP_FEE_MANAGER_ADDRESS, STABLECOIN_DEX_ADDRESS]; |
Contributor
There was a problem hiding this comment.
Can we also add TIP_20_ESCROW_PRECOMPILE to this, ig it also needs to be updated in the TIP itself.
CC: @danrobinson
Member
Author
There was a problem hiding this comment.
we don't yet have this const defined so i'd suggest we do it in scope of TIP-1034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CHAIN-1144
Adds
isImplicitlyApprovedmethod toAddressRegistryand changes stablecoind DEX to usesystem_transfer_frompost-T5.